Separate test and prod cache (+ ruff formatter) #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks for the quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, tests running locally can alter
huggingface_hubcache. Two majors cases happen:I previously tried to fix this problem using fixtures to use a separate cache and save/set back the registered token while running tests. But this is not really satisfying since cleanup fixtures might not be processed (if process is killed or if several pytests processed are run at once). This PR aims to definitely get rid of these problems by setting a test
HF_HOMEwhen running the tests. By doing so, there is no way staging and prod caches get mixed or corrupted.Looks like something I should have done long ago. Sorry for the inconveniences @McPatate 😄
Also I've been a bit too quick when replacing
blackwithruffin #1783. I fixed the makefile and github workflows in this PR to run both the linter and the formatter.